8320575: generic type information lost on mandated parameters of record's compact constructors

[GoeLin]

I backport this for parity with 21.0.6-oracle.

As the CSR for 21 says, I omit the specification changes.
These make the description more precise. As I understand,
the change brought to 21 is ok with the broader, unchanged
specification.

The rest applied clean.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8320575 needs maintainer approval
• Change requires CSR request JDK-8337480 to be approved

Warning

 ⚠️ Found leading lowercase letter in issue title for 8320575: generic type information lost on mandated parameters of record's compact constructors

Issues

• JDK-8320575: generic type information lost on mandated parameters of record's compact constructors (Bug - P3)
• JDK-8337480: generic type information lost on mandated parameters of record's compact constructors (CSR)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1026/head:pull/1026
$ git checkout pull/1026

Update a local copy of the PR:
$ git checkout pull/1026
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1026/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1026

View PR using the GUI difftool:
$ git pr show -t 1026

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1026.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (814954a7)
• 00: Full (9f4d1c53)

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

Hi @vicente-romero-oracle, @jddarcy, @weibxiao,
could one of you please verify whether I modified this correctly to match the backport CSR?
Thanks!

[weibxiao]

For class Excectable.java, three methods got changed. It seems you only modified one. All comments for the modified methods were not there.

[GoeLin]

Hi Weibing,

thanks for having a look!

Well, the comment of three methods got changed but only one has code changes. At least the public commit openjdk/jdk@7bf1989 touches only the code of getGenericParameterTypes().

I omitted the comments on purpose because the CSR for 21 8337480 does not mention the comment change as the original one 8321819 does. Also, I read the discussion in the comments like that.

So you are saying you backported all the comments to 21? If so. I'll add them, too.

Thanks, Goetz