8195675: Call to insertText with single character from custom Input Method ignored

[srl295]

• Backport of JDK-8195675
• Backport of openjdk/jdk@b8f2ec9 8195675: Call to insertText with single character from custom Input Method ignored jdk#17921

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8195675 needs maintainer approval

Issue

• JDK-8195675: Call to insertText with single character from custom Input Method ignored (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1052/head:pull/1052
$ git checkout pull/1052

Update a local copy of the PR:
$ git checkout pull/1052
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1052

View PR using the GUI difftool:
$ git pr show -t 1052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1052.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back srl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[srl295]

@prrace can I get a review here?

[srl295]

⚠️ Issue of type Backport is not allowed for integrations

Thought I was following https://openjdk.org/projects/jdk-updates/approval.html - do I use the original JBS number instead of creating a Backport issue?

[mlbridge]

Webrevs

• 01: Full - Incremental (843c2a53)
• 00: Full (fe19e362)

[srl295]

No code change - just restructured so it's an actual cherry-pick.

[openjdk]

@srl295 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[aivanov-jdk]

⚠️ Issue of type Backport is not allowed for integrations

Thought I was following https://openjdk.org/projects/jdk-updates/approval.html - do I use the original JBS number instead of creating a Backport issue?

You should set the title of the PR to Backport <hash> where <hash> is the real hash of the changeset you're backporting. In this case, the title should be Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd.

(For some reason, I cannot see this information in the Guide https://openjdk.org/guide/#backporting )

If the backport is clean, the Skara bot will add the clean label and will allow you to integrate the backport without requiring a code review after it's approved.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[srl295]

/integrate

[openjdk]

@srl295 This pull request has not yet been marked as ready for integration.

[srl295]

right - the bug isn't approved yet for backport. It's clean though.

[GoeLin]

Hi,
please add the Fix request comment to the real bug, not the Backport issue you opened. Please mention 21 as target.

[srl295]

Ok. El El mié, oct 16, 2024 a la(s) 8:01 a.m., Goetz Lindenmaier < ***@***.***> escribió:

…

Hi, please add the Fix request comment to the real bug, not the Backport issue you opened. Please mention 21 as target. — Reply to this email directly, view it on GitHub <#1052 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGQZM7Q5RGP4COIQGS6DT3Z3ZPUPAVCNFSM6AAAAABP5MHEGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJWG43TSMJYGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[srl295]

Hi, please add the Fix request comment to the real bug, not the Backport issue you opened. Please mention 21 as target.

Done.