Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 #523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 23, 2024

Uncleanliness comes from JDK 21 not having JDK-8313882, so I had to rewrite the incoming hunks back to INT64_FORMAT and int64_t casts. This can be made clean by JDK-8313882 backport, but it has follow-up bugs that break Graal. It seems a better choice to just do a little deviation here.

Additional testing:

  • MacOS AArch64 server fastdebug, new regression tests fail without the fix, pass with it
  • Linux AArch64 server fastdebug, all
  • Linux x86_64 server fastdebug, all

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8327743 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/523/head:pull/523
$ git checkout pull/523

Update a local copy of the PR:
$ git checkout pull/523
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/523/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 523

View PR using the GUI difftool:
$ git pr show -t 523

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/523.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 23, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 274c805c5137d9080a7670d864ecca8a0befc3f6 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 23, 2024
@shipilev shipilev marked this pull request as ready for review April 23, 2024 10:45
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 23, 2024
@shipilev shipilev marked this pull request as draft April 23, 2024 10:48
@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 23, 2024
@shipilev shipilev force-pushed the JDK-8327743-loom-jni-monitor-count branch from 1a23cf3 to 56522fa Compare April 29, 2024 10:06
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2024

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@shipilev shipilev force-pushed the JDK-8327743-loom-jni-monitor-count branch from 56522fa to 183d682 Compare July 15, 2024 11:25
@shipilev shipilev marked this pull request as ready for review July 15, 2024 15:14
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 15, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2024

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 9, 2024

@shipilev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Sep 9, 2024
@shipilev
Copy link
Member Author

/open

@openjdk openjdk bot reopened this Sep 10, 2024
@openjdk
Copy link

openjdk bot commented Sep 10, 2024

@shipilev This pull request is now open

@shipilev shipilev force-pushed the JDK-8327743-loom-jni-monitor-count branch from 183d682 to 29e62b8 Compare September 10, 2024 15:13
@openjdk
Copy link

openjdk bot commented Sep 10, 2024

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants