-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate #973
base: master
Are you sure you want to change the base?
8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate #973
Conversation
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, thanks.
/approval request This is a performance enhancement for Shenandoah. It's a clean backport and there are no changes outside of Shenandoah. I do not believe the macos test failure is related to this change. |
@earthling-amzn |
Please backport to 23 first. |
/approval request This is a performance enhancement for Shenandoah. It's a clean backport and there are no changes outside of Shenandoah. I do not believe the macos test failure is related to this change. We have been running this change in production for over a month now. This change has also been accepted in jdk23u. |
@earthling-amzn |
Clean backport. Change is confined to Shenandoah.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/973/head:pull/973
$ git checkout pull/973
Update a local copy of the PR:
$ git checkout pull/973
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/973/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 973
View PR using the GUI difftool:
$ git pr show -t 973
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/973.diff
Webrev
Link to Webrev Comment