Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prkoppul
Copy link

@prkoppul prkoppul commented Oct 14, 2024

clean backport


Progress

  • JDK-8331391 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/160/head:pull/160
$ git checkout pull/160

Update a local copy of the PR:
$ git checkout pull/160
$ git pull https://git.openjdk.org/jdk23u.git pull/160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 160

View PR using the GUI difftool:
$ git pr show -t 160

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/160.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2024

👋 Welcome back pkoppula! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport c9bee173d61f4accfc4adc280ab5d21600191756 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

⚠️ @prkoppul This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 14, 2024
@prkoppul
Copy link
Author

/approval

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@prkoppul usage: /approval [<id>] (request|cancel) [<text>]

@mlbridge
Copy link

mlbridge bot commented Oct 14, 2024

Webrevs

@prkoppul
Copy link
Author

/approval 8331391 request

@openjdk
Copy link

openjdk bot commented Oct 15, 2024

@prkoppul
8331391: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant