Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337753: Target class of upcall stub may be unloaded #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Oct 14, 2024

Backport of: openjdk/jdk#20479

There were some trivial conflicts in stubGenerator_aarch64.cpp and stubGenerator_riscv.cpp. Some code still there in jdk23, already removed in later versions.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8337753 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8337753: Target class of upcall stub may be unloaded (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/163/head:pull/163
$ git checkout pull/163

Update a local copy of the PR:
$ git checkout pull/163
$ git pull https://git.openjdk.org/jdk23u.git pull/163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 163

View PR using the GUI difftool:
$ git pr show -t 163

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/163.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2024

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 6af13580c2086afefde489275bc2353c2320ff3f 8337753: Target class of upcall stub may be unloaded Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

⚠️ @JornVernee This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 14, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 14, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant