Skip to content

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Jan 17, 2025

Also filtering /proc/self/smap as that is also a very "serviceability tool" thing to do.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8336: Socket Read rule should filter jfr recordings (Task - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/624/head:pull/624
$ git checkout pull/624

Update a local copy of the PR:
$ git checkout pull/624
$ git pull https://git.openjdk.org/jmc.git pull/624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 624

View PR using the GUI difftool:
$ git pr show -t 624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/624.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@thegreystone thegreystone requested a review from aptmac January 17, 2025 15:07
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2025

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr label Jan 17, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2025

Webrevs

@thegreystone thegreystone requested a review from Gunde January 22, 2025 16:32
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 14, 2025

@thegreystone This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2025

@thegreystone This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant