Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903971: Restore propagation of preview flag into library code #255

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Mar 13, 2025

Please review this change restoring the propagation of the preview flag into compilation of library code.

This will complete the removal of the problematic LIBRARY.properties implementation started with CODETOOLS-7903940

See:

if (runJavac && script.enablePreview() && !seenEnablePreview) {


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • CODETOOLS-7903971: Restore propagation of preview flag into library code (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/255/head:pull/255
$ git checkout pull/255

Update a local copy of the PR:
$ git checkout pull/255
$ git pull https://git.openjdk.org/jtreg.git pull/255/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 255

View PR using the GUI difftool:
$ git pr show -t 255

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/255.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2025

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants