-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8338867: GenShen: Do all size accounting in words #482
base: master
Are you sure you want to change the base?
8338867: GenShen: Do all size accounting in words #482
Conversation
👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@kdnilsen this pull request can not be integrated into git checkout do-all-size-accounting-in-words
git fetch https://git.openjdk.org/shenandoah.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
Also fix typos in spelling of proper_unit_for_byte_size()
…ll-size-accounting-in-words
…o represent words
…or_set() reports words transferred
…utator_set() reports words transferred
…d_reserves(), reserve_regions()
Draft while I work through the details of this
We want to consistently do all size accounting in words rather than a mix of bytes and words. This will affect both traditional Shenandoah and Generational Shenandoah implementations.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/482/head:pull/482
$ git checkout pull/482
Update a local copy of the PR:
$ git checkout pull/482
$ git pull https://git.openjdk.org/shenandoah.git pull/482/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 482
View PR using the GUI difftool:
$ git pr show -t 482
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/482.diff