8346307: [lworld] Clarify identity vs value in Class, Objects, and document limitations of value objects #1327
Conversation
…IdentityException Add APINote and javadoc for IdentityException where it will be useful to know. Simplified WeakHashMap javadoc updates for IdentityException. Added note to System.identityHashCode to include value objects.
|
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
|
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 639 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
…IdentityException Add APINote and javadoc for IdentityException where it will be useful to know. Updated Objects.hasIdentity to return true for non-null reference to identity class; else false Added Objects.isValueObject to return true for non-null reference to value class; else false Updated tests for value objects.
…tityexception' into 8346307-throws-identityexception
|
|
RogerRiggs
changed the title
|
@RogerRiggs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Does this intend to wait for openjdk/jdk#23395 or will it migrate from HTML after the taglet is available? |
|
I've been trying out the various incarnations of the javadoc support to see how they work, but that can be a separate PR when it settles. |
Add APINote and javadoc for IdentityException where it will be useful to know that identity or value objects are treated differently.
Simplified WeakHashMap javadoc updates for IdentityException.
Added note to System.identityHashCode to include value objects.
Added to class javadoc for IdentityHashMap for value objects.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1327/head:pull/1327$ git checkout pull/1327Update a local copy of the PR:
$ git checkout pull/1327$ git pull https://git.openjdk.org/valhalla.git pull/1327/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1327View PR using the GUI difftool:
$ git pr show -t 1327Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1327.diff
Using Webrev
Link to Webrev Comment