8372856: [lworld] link error in release build for oops/test_flatArrayOop.cpp

[tstuefe]

Simple error with a trivial fix. In release builds, flatArrayOopDesc::value_at_addr may be inlined, causing the non-inlined function not to exist and resulting in link errors if a call site does not include the inline hpp.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8372856: [lworld] link error in release build for oops/test_flatArrayOop.cpp (Bug - P4)

Reviewers

• Frederic Parain (@fparain - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1765/head:pull/1765
$ git checkout pull/1765

Update a local copy of the PR:
$ git checkout pull/1765
$ git pull https://git.openjdk.org/valhalla.git pull/1765/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1765

View PR using the GUI difftool:
$ git pr show -t 1765

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1765.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372856: [lworld] link error in release build for oops/test_flatArrayOop.cpp

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the lworld branch:

• bf9315f: 8372619: [lworld] Use Character caches in --enable-preview
• 702e610: 8372955: [lworld] The alternate substitutability method doesn't increment the offset when iterating over segments
• 428522c: 8372697: [lworld] compiler/c2/irTests/scalarReplacement/ScalarReplacementWithGCBarrierTests.java fails with --enable-preview
• ... and 1 more: https://git.openjdk.org/valhalla/compare/acb511a9f5c7b750b41e1ce77aab3d1a59613097...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fparain) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[fparain]

LGTM.

[mlbridge]

Webrevs

• 00: Full (ae4fd907)

[tstuefe]

For some reason, GHAs won't run for me in my valhalla fork. I opted in on GHAs for the fork. I also expected the usual mail/message from Skara Bot to invite me, but I've gotten nothing so far.

Other than that, this issue is so trivial that I may just push the fix if there are no objections.

[tstuefe]

Hearing no objections, I'll push now.

/integrate

[openjdk]

@tstuefe
Your change (at version ae4fd90) is now ready to be sponsored by a Committer.