-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add @mertcanaltin to regular members list #1292
Conversation
Hi Mert 👋 out of curiosity, have you attended or collaborated in any OpenJS Collaboration spaces? I haven't seen you in any meeting or space I'm aware of, so just asking out of curiosity :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, I prematurely approved here - one caveat I have is usually meeting/seeing someone on a CPC call (can do intros there if you haven't already come to a call before - if you already have then I apologize but hope to see you at the next one).
Next meeting is Tue, April 30, 12pm – 1pm ET (ref. to the events calendar:
https://calendar.google.com/calendar/u/0/embed?src=linuxfoundation.org_fuop4ufv766f9avc517ujs4i0g@group.calendar.google.com)
Just as a clarification, I don't want to be a gatekeeper, but we also shouldn't blindly approve PRs 🙈; I'd be more than happy to have you with us, Mert! But just please ensure you meet all the eligibility criteria as documented within this repo 🙏 |
yes I work in nodejs and express js, we worked together in crowdin @ovflowd, by the way I attend the meetings as a listener, I can attend the meeting you sent, I think I will succeed |
Yes, I remember you, Mert, not questioning that 🙃 |
By the way, I haven't become a collabrator yet and I really want to be and I try to make good contributions |
I read this part before I applied, I think I will be active I thought I could not participate because I was not cooperative for meet
|
If this is a requirement we should add it to the document, otherwise it seems non relevant. |
Agreed. We need to revisit our policies given the security concerns we have faced recently. I filed an issue to discuss this here (#1300). @mertcanaltin, please be patient while we get our policies in order, and please feel free to start joining our calls already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until we resolve #1300.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mertcanaltin,
Thank you so much for your interest in joining the CPC! I really appreciate it. At this moment, however, I don't feel confident approving your request.
I encourage you to attend more CPC meetings and actively participate in them, as well as engage with the Cross Project Council GitHub repository. Building a strong connection with the community and understanding what you want to contribute to the OpenJS community is very important.
While I can't approve your CPC membership request right now, I hope to see you around. Stay safe, and please feel free to join CPC meetings and stay active here ❤️
Keep in mind that I don't have the authority to approve/reject requests, so I don't speak for the CPC, but I speak as myself, as a CPC member :)
thank you very much for your answers, I will do my best |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on recent internal discussions, I'm removing my block to this PR.
And changing it to a +1. I do believe tho that having you taking part of our meetings and having presence is fundamental, so looking forward to it 🙃
This hasn't received four approval reviews yet, and there is still one blocking review. I believe this means we haven't reached a consensus on approving Mert's addition to the CPC. cc @openjs-foundation/cpc is this intentional? Do we want to approve this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the belated reply. Beyond the security concerns initially mentioned, which we're addressing separately, my personal concern was about CPC membership being something that you request once you demonstrate involvement that justifies it, not a prerequisite to getting involved. Maybe we need to make this more explicit. My understanding is that @mertcanaltin has now been joining calls, so I'll rescind my initial change request.
So, I guess we can merge this then :) |
Thank you |
hello everyone, I would like to join you, I am currently trying to contribute as much as I can under Node.js, I have learned a lot from the team and I continue to learn, my biggest motivation is to meet great people and learn something and reflect it as a contribution thank you all very much ❤️