-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add guide to community health files #1334
Conversation
We need to move the IP guidance file in this repo too, not sure what it's doing in |
Lol. @joesepi and I had the same thirst for cleaning things up around the same time but we sync'ed poorly. The organization of content in the repo and in the readme are all off as a result. :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started, @ctcpip, this is great!
A few (high-level) comments:
- Let's avoid setting policy in a guide as much as possible, especially if it conflicts with policy set elsewhere (e.g. the onboarding checklist)
- I think it's good to be pragmatic about the fact that every project is on GitHub, but we also want to acknowledge when things are github-specific and favor more neutral options whenever possible.
- Let's also include where the charter goes and so maybe rename the guide accordingly? "Project repository structure"?
- We use the term project to define a foundation project, so let's avoid mixing GitHub-specific organization/project lingo in here as much as possible.
Is this a general comment on future changes or are there specific instances in the document that are problematic?
We're not prescribing how their repository should be structured -- only guidance on community health files.
|
The latest changes address all comments -- and in a way that I hope folks will find satisfactory. Thanks for everyone's help and feedback! |
per my last comment, I am going to merge this. discussed with Tobie earlier today and concerns are addressed. if not, let's follow up with a new issue and PRs. I already have some new content to add to this, and will follow up. thanks again everyone! |
Co-authored-by: Tobie Langel <tobie@unlockopen.com> Signed-off-by: Chris de Almeida <ctcpip@users.noreply.github.com>
resolves #1263