feat: add jwt signing and verification logic #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
push-tags-from-workflow
bot
added
dependencies
NamanBalaji
force-pushed
the
feat/add-message-signing-package
branch
3 times, most recently
from
cbb12c6 to
51875d6
Compare
NamanBalaji
force-pushed
the
feat/add-message-signing-package
branch
from
51875d6 to
0f71483
Compare
|
cb80
reviewed
Nov 20, 2025
cb80
reviewed
Nov 20, 2025
Contributor
cb80
left a comment
cb80
left a comment
There was a problem hiding this comment.
Package signing is very much specific to JWT token, so I'd call it jwtsigning.
apatsap
approved these changes
Nov 20, 2025
fabenan-f
approved these changes
Nov 21, 2025
| tb.Helper() | ||
|
|
||
| key, err := rsa.GenerateKey(rand.Reader, bits) | ||
| if err != nil { |
There was a problem hiding this comment.
Since we are using an assertion package everywhere, I'd stick with it for consistency reasons
| assert.NoError(t, err) | ||
|
|
||
| body := []byte("message-body") | ||
| tokenStr, err := signer.Sign(context.Background(), body) |
There was a problem hiding this comment.
NIT: t.Context() (also at other places)
| return nil, ErrMissingIssOrKid | ||
| } | ||
|
|
||
| if len(v.trustedIssuers) > 0 { |
There was a problem hiding this comment.
We should return error early while initialization of the verifier itself cause if the trustedIssuers is empty or nil we might accept jwt token signed by any malicious entity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.