Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove docker dependency #1870

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

furykerry
Copy link
Member

Ⅰ. Describe what this PR does

remove unnecessary docker dependency and avoid potential security alerts

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.85%. Comparing base (0d0031a) to head (b736ef6).
Report is 139 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1870      +/-   ##
==========================================
+ Coverage   47.91%   50.85%   +2.93%     
==========================================
  Files         162      192      +30     
  Lines       23491    24950    +1459     
==========================================
+ Hits        11256    12688    +1432     
+ Misses      11014    10961      -53     
- Partials     1221     1301      +80     
Flag Coverage Δ
unittests 50.85% <ø> (+2.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@furykerry furykerry force-pushed the feature/removedocker branch 2 times, most recently from 992e32f to b6b7fa5 Compare December 30, 2024 07:55
Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com>
@furykerry furykerry force-pushed the feature/removedocker branch from b6b7fa5 to b736ef6 Compare December 30, 2024 09:28
@zmberg
Copy link
Member

zmberg commented Jan 2, 2025

/lgtm

@zmberg zmberg merged commit 42f5266 into openkruise:master Jan 2, 2025
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants