Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): lock min Python version to 3.7.9 #353

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

tombh
Copy link
Collaborator

@tombh tombh commented Jul 29, 2023

Github Actions for windows uses Python 3.7.9 not 3.7.16. This wasn't picked up in the PR that introduced the original lock because of dependency caching. See:

https://github.com/openlawlibrary/pygls/actions/runs/5702563535/job/15454396739#step:6:12

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

Github Actions for windows uses Python 3.7.9 not 3.7.16. This wasn't
picked up in the PR that introduced the original lock because of
dependency caching. See:

https://github.com/openlawlibrary/pygls/actions/runs/5702563535/job/15454396739#step:6:12
@tombh tombh requested a review from alcarney July 29, 2023 22:16
@tombh tombh merged commit acc239a into main Jul 29, 2023
30 checks passed
@tombh tombh deleted the tombh/lock-min-python-to-3.7.9 branch July 29, 2023 22:16
@tombh
Copy link
Collaborator Author

tombh commented Jul 29, 2023

Oh! You already approved it, thank you 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants