Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for notebook document sync methods #356

Merged
merged 12 commits into from
Sep 19, 2023

Commits on Sep 10, 2023

  1. refactor: rename <verb>_document to <verb>_text_document

    Now that there is a distinction between text documents and notebook
    documents, this commit renames the methods which act on text documents
    accordingly.
    
    The previous method names will still work, but now emit deprecation
    warnings
    alcarney committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    de56480 View commit details
    Browse the repository at this point in the history
  2. feat: allow servers to provide NotebookDocumentSyncOptions

    In order to enable `notebookDocument/did*` messages from the client, a
    server must provide its chosen `NotebookDocumentSyncOptions` as part
    of its `ServerCapabilities`.
    
    This commit adds a new `notebook_document_sync` option to the
    `LanguageServer` constructor allowing this option to be set.
    alcarney committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    feb0e74 View commit details
    Browse the repository at this point in the history
  3. refactor: expose workspace via a property

    To stop type checkers like pyright complaining about the possibility
    of `self.workspace` being `None`, the workspace is now stored in
    `self._workspace` and accessed by via a property.
    
    This property performs the check for `None` and raises a RuntimeError
    accordingly
    alcarney committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    4c194b5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    67685ea View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a63892d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    23e3f23 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8f68b5a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4bcaed5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2b7ac1d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    529b275 View commit details
    Browse the repository at this point in the history
  11. fix: mypy lints

    alcarney committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    2b18b01 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4774f52 View commit details
    Browse the repository at this point in the history