-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for notebook document sync methods #356
Merged
Commits on Sep 10, 2023
-
refactor: rename
<verb>_document
to<verb>_text_document
Now that there is a distinction between text documents and notebook documents, this commit renames the methods which act on text documents accordingly. The previous method names will still work, but now emit deprecation warnings
Configuration menu - View commit details
-
Copy full SHA for de56480 - Browse repository at this point
Copy the full SHA de56480View commit details -
feat: allow servers to provide
NotebookDocumentSyncOptions
In order to enable `notebookDocument/did*` messages from the client, a server must provide its chosen `NotebookDocumentSyncOptions` as part of its `ServerCapabilities`. This commit adds a new `notebook_document_sync` option to the `LanguageServer` constructor allowing this option to be set.
Configuration menu - View commit details
-
Copy full SHA for feb0e74 - Browse repository at this point
Copy the full SHA feb0e74View commit details -
refactor: expose workspace via a property
To stop type checkers like pyright complaining about the possibility of `self.workspace` being `None`, the workspace is now stored in `self._workspace` and accessed by via a property. This property performs the check for `None` and raises a RuntimeError accordingly
Configuration menu - View commit details
-
Copy full SHA for 4c194b5 - Browse repository at this point
Copy the full SHA 4c194b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67685ea - Browse repository at this point
Copy the full SHA 67685eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a63892d - Browse repository at this point
Copy the full SHA a63892dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23e3f23 - Browse repository at this point
Copy the full SHA 23e3f23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f68b5a - Browse repository at this point
Copy the full SHA 8f68b5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bcaed5 - Browse repository at this point
Copy the full SHA 4bcaed5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b7ac1d - Browse repository at this point
Copy the full SHA 2b7ac1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 529b275 - Browse repository at this point
Copy the full SHA 529b275View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b18b01 - Browse repository at this point
Copy the full SHA 2b18b01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4774f52 - Browse repository at this point
Copy the full SHA 4774f52View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.