Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add PULL_REQUEST_TEMPLATE; update changelog #49

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

n-dusan
Copy link
Contributor

@n-dusan n-dusan commented Aug 22, 2024

No description provided.

@n-dusan n-dusan self-assigned this Aug 22, 2024
@n-dusan n-dusan requested a review from tombh August 22, 2024 22:09
Copy link
Contributor

@tombh tombh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small point, I think the feat tag in commits is associated with a feature in the main application itself, therefore something that warrants an associated minor version change. Here, the only thing changes is a special Github file that doesn't affect the main application itself.

@n-dusan
Copy link
Contributor Author

n-dusan commented Aug 23, 2024

Thanks, I think that's right. I'll squash this pr to keep the chore: prefix only.

@n-dusan n-dusan merged commit a8fc048 into main Aug 23, 2024
4 checks passed
@n-dusan n-dusan deleted the ndusan/update-changelog branch August 23, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants