Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve to _api/versions requests without trailing / #52

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

n-dusan
Copy link
Contributor

@n-dusan n-dusan commented Sep 25, 2024

Description (e.g. "Related to ...", etc.)

Closes #51

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

Automated tests, benchmarks and linters

You can run the tests, lints and benchmarks that are run on CI locally with:

just ci

This resolves an issue where `compare_date` and `_date` were not getting
mapped correctly.
@n-dusan n-dusan self-assigned this Sep 25, 2024
@n-dusan n-dusan added the bug Something isn't working label Sep 25, 2024
@n-dusan n-dusan merged commit 8c40d26 into main Sep 25, 2024
4 checks passed
@n-dusan n-dusan deleted the ndusan/fix-trailing-slash-versions branch September 25, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix _api_versions not resolving _date, _compare without a trailing /
2 participants