Conversation
# Conflicts: # server/grails-app/services/org/gokb/PackageSourceUpdateService.groovy
mask passwords in admin ui
# Conflicts: # server/build.gradle # server/grails-app/services/org/gokb/PackageSourceUpdateService.groovy
- regard expected and retired titles for tipp-count in wekb-import
There was a problem hiding this comment.
All of the methods in this controller should be restricted to ROLE_CONTRIBUTOR.
| user = User.get(springSecurityService.principal?.id) | ||
| } | ||
|
|
||
| params['_embed'] = params['_embed'] ?: 'identifiedComponents' |
There was a problem hiding this comment.
Not really applicable for this class of objects. Don't think we would have any embeds.
| ftpServer = new FakeFtpServer() | ||
| ftpServer.setServerControlPort(MOCKSERVER_PORT) | ||
| FileSystem fileSystem = new UnixFakeFileSystem() | ||
| fileSystem.add(new FileEntry(NON_KBART_FILE, CONTENTS)) | ||
| ftpServer.setFileSystem(fileSystem) | ||
| ftpServer.addUserAccount(new UserAccount(USER, PASSWORD, HOME_DIR)) | ||
|
|
||
| ftpServer.start() |
There was a problem hiding this comment.
It might be best do do this once for all tests, and then make sure to only do the stop() after the last test.
| String principal //legacy | ||
| String credentials //legacy | ||
| User owner | ||
| String ba_username |
There was a problem hiding this comment.
Properties should be in camel case, which should then be explicitly mapped to a pascal case column name via mapping, for example ep_url with the prefix for endPoint . The prefix ba is too cryptic here and should be replaced by a more descriptive one.
| resultList*.remove('ba_password') | ||
| resultList*.remove('ba_username') | ||
|
|
||
| if (params['method']) { |
There was a problem hiding this comment.
Filtering after the fact is not permissible, since it may invalidate the pagination info. Custom logic should be added in componentLookupService.restLookup if necessary.
|
|
||
| if (result.data) { | ||
| def resultList = result.data | ||
| resultList*.remove('ba_password') |
There was a problem hiding this comment.
Mapping configuration for this should be set in the domain class via jsonMapping.ignore.
| def resultList = result.data | ||
|
|
||
| if(resultList.size() > 0){ | ||
| resultList*.remove('ba_password') |
server/src/integration-test/groovy/org/gokb/UpdatePackageRunFTPSpec.groovy
Outdated
Show resolved
Hide resolved
2 participants
No description provided.