Build NCrystal from Source for OpenMC #3304
Open
+36
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the OpenMC build process to compile NCrystal from source instead of relying on the manylinux-provided package. The motivation behind this change is to ensure a more streamlined integration, avoiding unnecessary dependencies and improving compatibility.
Motivation
Using the manylinux version results in a dependency on
libNCrystal.so
, which is dynamically loaded viasubprocess
, adding inefficiencies.Setting
LD_LIBRARY_PATH
is an option, but it introduces complexity.Reference
This PR follows up on discussions in another PR (shimwell/openmc/pull/67), where the issue of dependency management was raised. As suggested, this change is being made separately to integrate source-built NCrystal before addressing packaging concerns.