Feat: Add Ref of parent node to child node #520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@SimonBurmer but that is handled by the Luigi all the children nodes get parent node ref, there is no need to do it in this repo. 
|
gkrajniak
requested changes
Dec 9, 2025
| globalNodes.forEach((node) => { | ||
| node.context = { ...node.context }; | ||
| node.globalNav = this.isGlobalNavNode(node); | ||
| node.parent = undefined; |
Contributor
|
Thanks for replying @gkrajniak we found out that during the node processing by the server, the parent relation is not maintained by luigi yet. But we cannot use the processor anyhow and needed to move to the https://docs.luigi-project.io/docs/navigation-parameters-reference?section=onnodeactivation api. So its correct to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a ref of the parent node to the current child node. This ref is needed to correctly traverse the reference tree from a child node up to the parent node. A progress needed when wanting to apply (e.g. redirecting) changes to all nodes in a reference tree, starting from a child.