Fix out of bounds when verifying malformed proofs

openmina · Feb 24, 2025 · 1e9a54b · 1e9a54b
1 parent dec49a9
commit 1e9a54b
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/poly-commitment/src/commitment.rs b/poly-commitment/src/commitment.rs
@@ -738,6 +738,13 @@ impl<G: CommitmentCurve> SRS<G> {
             };
 
             let s = b_poly_coefficients(&chal);
+
+            debug_assert!(s.len() <= scalars.len());
+
+            // TODO: implement a better solution at type/wire level, for now we just bail out...
+            if s.len() > scalars.len() {
+                return false;
+            }
 
             let neg_rand_base_i = -rand_base_i;