-
-
Notifications
You must be signed in to change notification settings - Fork 26
New next app β Home Page, Datasets Header, and Slide-out Sidebar #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HelderMendes
wants to merge
2
commits into
openml:master
Choose a base branch
from
HelderMendes:new-next-app
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't add readmes for a PR. Just add this information in the PR description on GitHub |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,36 +19,36 @@ Migrated all entity detail pages to use descriptive, SEO-optimized URLs: | |
|
|
||
| **Benefits:** | ||
|
|
||
| - Better Google indexing and SEO ranking | ||
| - More intuitive, user-friendly URLs | ||
| - Improved sharing and citation experience | ||
| - Professional URL structure for academic references | ||
| - Better Google indexing and SEO ranking | ||
| - More intuitive, user-friendly URLs | ||
| - Improved sharing and citation experience | ||
| - Professional URL structure for academic referencesx | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added typo :) |
||
|
|
||
| ### 2. **Backward Compatibility Redirects** π | ||
|
|
||
| Old URLs automatically redirect to new canonical URLs to maintain compatibility with: | ||
|
|
||
| - Academic papers and citations | ||
| - Bookmarks and saved links | ||
| - External references | ||
| - Academic papers and citations | ||
| - Bookmarks and saved links | ||
| - External references | ||
|
|
||
| **Implementation:** | ||
|
|
||
| - `/d/[dataId].js` β Redirects to `/datasets/[id]` | ||
| - `/t/[taskId].js` β Redirects to `/tasks/[id]` | ||
| - `/f/[flowId].js` β Redirects to `/flows/[id]` | ||
| - `/r/[runId].js` β Redirects to `/runs/[id]` | ||
| - `/d/[dataId].js` β Redirects to `/datasets/[id]` | ||
| - `/t/[taskId].js` β Redirects to `/tasks/[id]` | ||
| - `/f/[flowId].js` β Redirects to `/flows/[id]` | ||
| - `/r/[runId].js` β Redirects to `/runs/[id]` | ||
|
|
||
| ### 3. **Fixed Search Result Navigation** π | ||
|
|
||
| Search results now correctly navigate to the new SEO-friendly URLs: | ||
|
|
||
| **Files Modified:** | ||
|
|
||
| - `app/src/components/search/ResultCard.js` | ||
| - Added entity type detection via `_meta.rawHit._type` | ||
| - Added ID field mapping for each entity type | ||
| - Implemented URL generation based on entity type | ||
| - `app/src/components/search/ResultCard.js` | ||
| - Added entity type detection via `_meta.rawHit._type` | ||
| - Added ID field mapping for each entity type | ||
| - Implemented URL generation based on entity type | ||
|
|
||
| **Logic:** | ||
|
|
||
|
|
@@ -72,112 +72,111 @@ Enhanced `OpenMLSearchConnector.js` to properly handle entity types: | |
|
|
||
| **Changes:** | ||
|
|
||
| - Added `_meta.rawHit._type` field with index name | ||
| - Ensures entity type is correctly passed to search results | ||
| - Enables proper routing based on entity type | ||
| - Added `_meta.rawHit._type` field with index name | ||
| - Ensures entity type is correctly passed to search results | ||
| - Enables proper routing based on entity type | ||
|
|
||
| ### 5. **Search Configuration Updates** βοΈ | ||
|
|
||
| Updated search configs to include necessary ID fields: | ||
|
|
||
| **Files Modified:** | ||
|
|
||
| - `app/src/search_configs/runConfig.js` - Added `run_id` to result_fields | ||
| - `app/src/search_configs/runConfig.js` - Added `run_id` to result_fields | ||
|
|
||
| ### 6. **Component Fixes** π | ||
|
|
||
| Fixed display issues in search result cards: | ||
|
|
||
| **Files Modified:** | ||
|
|
||
| - `app/src/components/search/taskCard.js` | ||
| - `app/src/components/search/taskCard.js` | ||
| - Fixed Title to use `tasktype.name` and `source_data.name` | ||
| - Was incorrectly using run fields | ||
|
|
||
| - Fixed Title to use `tasktype.name` and `source_data.name` | ||
| - Was incorrectly using run fields | ||
|
|
||
| - `app/src/components/search/flowCard.js` | ||
| - Fixed Title to use `name` field | ||
| - Was incorrectly using run fields | ||
| - `app/src/components/search/flowCard.js` | ||
| - Fixed Title to use `name` field | ||
| - Was incorrectly using run fields | ||
|
|
||
| ### 7. **Detail Page Migrations** π | ||
|
|
||
| Moved all entity detail pages to their new canonical locations: | ||
|
|
||
| **Datasets:** | ||
|
|
||
| - Content moved: `/d/[dataId].js` β `/datasets/[id].js` | ||
| - Updated param name: `params.dataId` β `params.id` | ||
| - Updated internal links to use new URLs | ||
| - Content moved: `/d/[dataId].js` β `/datasets/[id].js` | ||
| - Updated param name: `params.dataId` β `params.id` | ||
| - Updated internal links to use new URLs | ||
|
|
||
| **Tasks:** | ||
|
|
||
| - Content moved: `/t/[taskId].js` β `/tasks/[id].js` | ||
| - Updated param name: `params.taskId` β `params.id` | ||
| - Updated internal links: `/d/` β `/datasets/` | ||
| - Content moved: `/t/[taskId].js` β `/tasks/[id].js` | ||
| - Updated param name: `params.taskId` β `params.id` | ||
| - Updated internal links: `/d/` β `/datasets/` | ||
|
|
||
| **Flows:** | ||
|
|
||
| - Content moved: `/f/[flowId].js` β `/flows/[id].js` | ||
| - Updated param name: `params.flowId` β `params.id` | ||
| - Content moved: `/f/[flowId].js` β `/flows/[id].js` | ||
| - Updated param name: `params.flowId` β `params.id` | ||
|
|
||
| **Runs:** | ||
|
|
||
| - Content moved: `/r/[runId].js` β `/runs/[id].js` | ||
| - Updated param name: `params.runId` β `params.id` | ||
| - Updated internal links: `/d/` β `/datasets/`, `/t/` β `/tasks/`, `/f/` β `/flows/` | ||
| - Content moved: `/r/[runId].js` β `/runs/[id].js` | ||
| - Updated param name: `params.runId` β `params.id` | ||
| - Updated internal links: `/d/` β `/datasets/`, `/t/` β `/tasks/`, `/f/` β `/flows/` | ||
|
|
||
| ## Testing Checklist β | ||
|
|
||
| - [x] Datasets search page displays correctly | ||
| - [x] Tasks search page displays correctly | ||
| - [x] Flows search page displays correctly | ||
| - [x] Runs search page displays correctly | ||
| - [x] Clicking dataset leads to `/datasets/:id` | ||
| - [x] Clicking task leads to `/tasks/:id` | ||
| - [x] Clicking flow leads to `/flows/:id` | ||
| - [x] Clicking run leads to `/runs/:id` | ||
| - [x] Old `/d/:id` URLs redirect to `/datasets/:id` | ||
| - [x] Old `/t/:id` URLs redirect to `/tasks/:id` | ||
| - [x] Old `/f/:id` URLs redirect to `/flows/:id` | ||
| - [x] Old `/r/:id` URLs redirect to `/runs/:id` | ||
| - [x] Detail pages load correctly with new URLs | ||
| - [x] Internal links use new URL structure | ||
| - [x] Datasets search page displays correctly | ||
| - [x] Tasks search page displays correctly | ||
| - [x] Flows search page displays correctly | ||
| - [x] Runs search page displays correctly | ||
| - [x] Clicking dataset leads to `/datasets/:id` | ||
| - [x] Clicking task leads to `/tasks/:id` | ||
| - [x] Clicking flow leads to `/flows/:id` | ||
| - [x] Clicking run leads to `/runs/:id` | ||
| - [x] Old `/d/:id` URLs redirect to `/datasets/:id` | ||
| - [x] Old `/t/:id` URLs redirect to `/tasks/:id` | ||
| - [x] Old `/f/:id` URLs redirect to `/flows/:id` | ||
| - [x] Old `/r/:id` URLs redirect to `/runs/:id` | ||
| - [x] Detail pages load correctly with new URLs | ||
| - [x] Internal links use new URL structure | ||
|
|
||
| ## Files Changed | ||
|
|
||
| ### New Files Created: | ||
|
|
||
| - `/app/src/pages/datasets/[id].js` - Dataset detail page (canonical) | ||
| - `/app/src/pages/tasks/[id].js` - Task detail page (canonical) | ||
| - `/app/src/pages/flows/[id].js` - Flow detail page (canonical) | ||
| - `/app/src/pages/runs/[id].js` - Run detail page (canonical) | ||
| - `/app/src/pages/datasets/[id].js` - Dataset detail page (canonical) | ||
| - `/app/src/pages/tasks/[id].js` - Task detail page (canonical) | ||
| - `/app/src/pages/flows/[id].js` - Flow detail page (canonical) | ||
| - `/app/src/pages/runs/[id].js` - Run detail page (canonical) | ||
|
|
||
| ### Modified Files: | ||
|
|
||
| - `/app/src/pages/d/[dataId].js` - Now redirects to `/datasets/:id` | ||
| - `/app/src/pages/t/[taskId].js` - Now redirects to `/tasks/:id` | ||
| - `/app/src/pages/f/[flowId].js` - Now redirects to `/flows/:id` | ||
| - `/app/src/pages/r/[runId].js` - Now redirects to `/runs/:id` | ||
| - `/app/src/components/search/ResultCard.js` - Added entity-aware URL generation | ||
| - `/app/src/components/search/taskCard.js` - Fixed Title component | ||
| - `/app/src/components/search/flowCard.js` - Fixed Title component | ||
| - `/app/src/services/OpenMLSearchConnector.js` - Added entity type metadata | ||
| - `/app/src/search_configs/runConfig.js` - Added run_id field | ||
| - `/app/src/pages/d/[dataId].js` - Now redirects to `/datasets/:id` | ||
| - `/app/src/pages/t/[taskId].js` - Now redirects to `/tasks/:id` | ||
| - `/app/src/pages/f/[flowId].js` - Now redirects to `/flows/:id` | ||
| - `/app/src/pages/r/[runId].js` - Now redirects to `/runs/:id` | ||
| - `/app/src/components/search/ResultCard.js` - Added entity-aware URL generation | ||
| - `/app/src/components/search/taskCard.js` - Fixed Title component | ||
| - `/app/src/components/search/flowCard.js` - Fixed Title component | ||
| - `/app/src/services/OpenMLSearchConnector.js` - Added entity type metadata | ||
| - `/app/src/search_configs/runConfig.js` - Added run_id field | ||
|
|
||
| ## SEO Impact π | ||
|
|
||
| **Before:** | ||
|
|
||
| - URLs like `/d/123`, `/t/456` are not descriptive | ||
| - Search engines can't understand content from URL | ||
| - Poor user experience when sharing links | ||
| - URLs like `/d/123`, `/t/456` are not descriptive | ||
| - Search engines can't understand content from URL | ||
| - Poor user experience when sharing links | ||
|
|
||
| **After:** | ||
|
|
||
| - URLs like `/datasets/123`, `/tasks/456` are self-documenting | ||
| - Better search engine indexing | ||
| - Professional appearance for academic citations | ||
| - Improved social media sharing with descriptive URLs | ||
| - URLs like `/datasets/123`, `/tasks/456` are self-documenting | ||
| - Better search engine indexing | ||
| - Professional appearance for academic citations | ||
| - Improved social media sharing with descriptive URLs | ||
|
|
||
| ## Breaking Changes β οΈ | ||
|
|
||
|
|
@@ -187,13 +186,13 @@ Moved all entity detail pages to their new canonical locations: | |
|
|
||
| For developers working with links: | ||
|
|
||
| - Update any hardcoded links to use new URL structure | ||
| - Internal links already updated in this PR | ||
| - External links will redirect automatically | ||
| - Update any hardcoded links to use new URL structure | ||
| - Internal links already updated in this PR | ||
| - External links will redirect automatically | ||
|
|
||
| ## Documentation Updated | ||
|
|
||
| - `TEAM_REPORT.md` - Updated with new URL structure and redirect information | ||
| - `TEAM_REPORT.md` - Updated with new URL structure and redirect information | ||
|
|
||
| ## Related Issues | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't edit .env - we don't want to overwrite variables on the server. You can use .env.dev or create a new file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood! I'll use the existing .env.dev for local development going forward. The new PR won't include any
.env changes - it will remain as the production configuration.