TRUNK-6296: Replace PowerMock Usage Due to Limited Support in Modern Java Versions #4905
Conversation
wikumChamith
force-pushed
the
TRUNK-6296
branch
5 times, most recently
from
9d48b82 to
e2e016e
Compare
wikumChamith
force-pushed
the
TRUNK-6296
branch
from
e2e016e to
ea6b4bc
Compare
|
Do we have modules that are still using PowerMock? If yes, what plans do we have for their migration? |
Since PowerMock is only used for testing, this won't impact any modules at runtime. However, moving forward, any module that plans to use the latest version of openmrs-core as a dependency should avoid using PowerMock |
Perhaps this is a plausible temporary solution: https://stackoverflow.com/a/71203428 |
We used that here: openmrs/openmrs-module-uiframework@ff12904 However, it would be better to try to avoid it. |
Description of what I changed
Issue I worked on
see https://openmrs.atlassian.net/browse/TRUNK-6296
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master