Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test) O3-3517: Run E2E Tests on Push and Pull Requests #821

Merged
merged 7 commits into from
Jul 2, 2024
Merged

(test) O3-3517: Run E2E Tests on Push and Pull Requests #821

merged 7 commits into from
Jul 2, 2024

Conversation

Bcoderx6
Copy link
Contributor

@Bcoderx6 Bcoderx6 commented Jul 2, 2024

https://openmrs.atlassian.net/browse/O3-3517

This PR introduces a new GitHub Actions workflow to run end-to-end (E2E) tests on every commit and pull request (PR) to the main branch. The new workflow is based on the existing E2E workflow used for releases but is modified to remove tag checkouts, ensuring that all tests are executed against the head of each monorepo @jayasanka-sack

Yasindu Dissanayake and others added 2 commits July 2, 2024 02:20
Enhance E2E Testing: Run E2E Tests on Every Commit and PR
@Bcoderx6 Bcoderx6 marked this pull request as draft July 2, 2024 01:50
@Bcoderx6 Bcoderx6 marked this pull request as ready for review July 2, 2024 01:50
@Bcoderx6 Bcoderx6 marked this pull request as draft July 2, 2024 01:50
@Bcoderx6 Bcoderx6 marked this pull request as ready for review July 2, 2024 04:01
@Bcoderx6 Bcoderx6 marked this pull request as draft July 2, 2024 04:01
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @Bcoderx6! I’ve added a few minor comments for you to review.

.github/workflows/e2e-tests-on-commit.yml. Outdated Show resolved Hide resolved
.github/workflows/e2e-tests-on-commit.yml. Outdated Show resolved Hide resolved
@jayasanka-sack
Copy link
Member

Also fix the filename: .github/workflows/e2e-tests-on-commit.yml. -> .github/workflows/e2e-tests-on-commit.yml (extra dot at the end)

Bcoderx6 and others added 2 commits July 2, 2024 15:26
Co-authored-by: Jayasanka Weerasinghe <33048395+jayasanka-sack@users.noreply.github.com>
Co-authored-by: Jayasanka Weerasinghe <33048395+jayasanka-sack@users.noreply.github.com>
- uses: actions/checkout@v4
with:
fetch-depth: 0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Bcoderx6 and others added 2 commits July 2, 2024 15:46
Co-authored-by: Jayasanka Weerasinghe <33048395+jayasanka-sack@users.noreply.github.com>
@Bcoderx6
Copy link
Contributor Author

Bcoderx6 commented Jul 2, 2024

Thank you, @jayasanka-sack! I’ve fixed the issues you mentioned. Please have another look and let me know if there are any more changes needed.

@Bcoderx6 Bcoderx6 marked this pull request as ready for review July 2, 2024 10:34
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done @Bcoderx6 ! 👏

@jayasanka-sack jayasanka-sack changed the title Enhance E2E Testing: Run E2E Tests on Every Commit and PR (test): Run E2E Tests on Push and Pull Requests Jul 2, 2024
@jayasanka-sack jayasanka-sack merged commit 87b6d50 into openmrs:main Jul 2, 2024
11 of 13 checks passed
@jayasanka-sack jayasanka-sack changed the title (test): Run E2E Tests on Push and Pull Requests (test) O3-3517: Run E2E Tests on Push and Pull Requests Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants