Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) O3-3551: Use actions/checkout@v4 in GH actions #823

Merged
merged 9 commits into from
Jul 5, 2024
Merged

(chore) O3-3551: Use actions/checkout@v4 in GH actions #823

merged 9 commits into from
Jul 5, 2024

Conversation

Bcoderx6
Copy link
Contributor

@Bcoderx6 Bcoderx6 commented Jul 4, 2024

https://openmrs.atlassian.net/browse/O3-3551

This update improves our CI pipeline by upgrading actions/checkout from v2 to v4, using Node.js 16 instead of Node.js 12. This change boosts performance and security. The updated workflow has been tested and works without errors. @jayasanka-sack

Yasindu Dissanayake and others added 9 commits July 2, 2024 02:20
Enhance E2E Testing: Run E2E Tests on Every Commit and PR
Co-authored-by: Jayasanka Weerasinghe <33048395+jayasanka-sack@users.noreply.github.com>
Co-authored-by: Jayasanka Weerasinghe <33048395+jayasanka-sack@users.noreply.github.com>
Co-authored-by: Jayasanka Weerasinghe <33048395+jayasanka-sack@users.noreply.github.com>
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @Bcoderx6!

General advice: When working on a PR, it's always best to create a new branch. Naming the branch with the relevant ticket number can help you keep track of your work. This allows you to:

  1. work on multiple PRs simultaneously
  2. prevent the inclusion of older commits, as seen in this PR (which contains 8 outdated commits).

@jayasanka-sack jayasanka-sack marked this pull request as ready for review July 4, 2024 13:54
@jayasanka-sack
Copy link
Member

Also, can you update the PR title with the ticket number and the keyword? You can find a list of best practices here: https://o3-docs.openmrs.org/docs/frontend-modules/contributing.en-US#pull-requests

@Bcoderx6 Bcoderx6 changed the title Upgrade GitHub Actions checkout from v2 to v4 03-3551: Upgrade GitHub Actions checkout from v2 to v4 Jul 4, 2024
@Bcoderx6 Bcoderx6 changed the title 03-3551: Upgrade GitHub Actions checkout from v2 to v4 (03-3551) Update GitHub Actions: Use Latest versions of actions/checkout Jul 4, 2024
@Bcoderx6
Copy link
Contributor Author

Bcoderx6 commented Jul 4, 2024

Thanks for the feedback, @jayasanka-sack !

For future PRs, I'll ensure to create a new branch named with the relevant ticket number to keep track of my work. This will help in managing multiple PRs simultaneously and prevent including outdated commits.

I'll update the PR title with the ticket number and keyword as suggested. For best practices, I'll refer to the guidelines at OpenMRS Contributing Guide.

@Bcoderx6 Bcoderx6 changed the title (03-3551) Update GitHub Actions: Use Latest versions of actions/checkout (03-3551): Improvement GitHub Actions - Use Latest versions of actions/checkout Jul 4, 2024
@Bcoderx6 Bcoderx6 changed the title (03-3551): Improvement GitHub Actions - Use Latest versions of actions/checkout (O3-3551): Improvement GitHub Actions - Use Latest versions of actions/checkout Jul 4, 2024
@jayasanka-sack jayasanka-sack changed the title (O3-3551): Improvement GitHub Actions - Use Latest versions of actions/checkout (chore) O3-3551: Use actions/checkout@v4 in GH actions Jul 5, 2024
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bcoderx6 !

@jayasanka-sack jayasanka-sack merged commit 8cc90db into openmrs:main Jul 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants