-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) O3-3551: Use actions/checkout@v4 in GH actions #823
Conversation
Enhance E2E Testing: Run E2E Tests on Every Commit and PR
Co-authored-by: Jayasanka Weerasinghe <33048395+jayasanka-sack@users.noreply.github.com>
Co-authored-by: Jayasanka Weerasinghe <33048395+jayasanka-sack@users.noreply.github.com>
Co-authored-by: Jayasanka Weerasinghe <33048395+jayasanka-sack@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @Bcoderx6!
General advice: When working on a PR, it's always best to create a new branch. Naming the branch with the relevant ticket number can help you keep track of your work. This allows you to:
- work on multiple PRs simultaneously
- prevent the inclusion of older commits, as seen in this PR (which contains 8 outdated commits).
Also, can you update the PR title with the ticket number and the keyword? You can find a list of best practices here: https://o3-docs.openmrs.org/docs/frontend-modules/contributing.en-US#pull-requests |
Thanks for the feedback, @jayasanka-sack ! For future PRs, I'll ensure to create a new branch named with the relevant ticket number to keep track of my work. This will help in managing multiple PRs simultaneously and prevent including outdated commits. I'll update the PR title with the ticket number and keyword as suggested. For best practices, I'll refer to the guidelines at OpenMRS Contributing Guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Bcoderx6 !
https://openmrs.atlassian.net/browse/O3-3551
This update improves our CI pipeline by upgrading actions/checkout from v2 to v4, using Node.js 16 instead of Node.js 12. This change boosts performance and security. The updated workflow has been tested and works without errors. @jayasanka-sack