Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Use referenceapplication content package #873

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

jayasanka-sack
Copy link
Member

@jayasanka-sack jayasanka-sack commented Jan 6, 2025

This PR introduces the use of content packages within the OpenMRS distribution. This enables the use of standardized content packages in the distribution, improving maintainability.

Changes Made

  • Upgraded the openmrs-sdk-maven-plugin to the latest snapshot version to support content package management.
  • Updated the distro.properties file to include the referenceapplication content package.
  • Deleted configurations that are already present in the referenceapplication content package
  • Updated the Dockerfile to match the new file structure of the SDK
  • Created a new bamboo plan for the referenceapplication repo: https://ci.openmrs.org/browse/CH-CONREF

@jayasanka-sack jayasanka-sack marked this pull request as draft January 6, 2025 18:04
@jayasanka-sack
Copy link
Member Author

So, the setup currently imports all the backend config from content packages, but it doesn’t seem to be importing locations when the app starts up. I’m not sure why this is happening, but I’m on the case of finding out!

@jayasanka-sack
Copy link
Member Author

jayasanka-sack commented Jan 7, 2025

Startup logs:
logs.txt

Fixed with openmrs/openmrs-content-referenceapplication@767f58d

@jayasanka-sack jayasanka-sack marked this pull request as ready for review January 16, 2025 11:25
@jayasanka-sack jayasanka-sack changed the title Use referenceapplication content package (feat) Use referenceapplication content package Jan 16, 2025
@jayasanka-sack
Copy link
Member Author

@ibacher, could you take a look at this? The PR is all set to be merged. 🥳

Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks!

@ibacher ibacher merged commit 5c51ed4 into openmrs:main Jan 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants