(style) O3-3579 : Changing the styles for help menu and devtools #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vijaykv5
changed the title
Comment on lines
7
to
10
| flex: auto; | ||
| bottom: 5rem; | ||
| bottom: 2rem; | ||
| right: 3rem; | ||
| width: 11rem; |
There was a problem hiding this comment.
Shall we use px here too? The reason is that rem is relative to your screen, so the spaces will differ from screen to screen. The idea is to use the same unit for both icons.
There was a problem hiding this comment.
Sorry, this comment is meant to be for the help icon.
There was a problem hiding this comment.
Got it!
but as per reference to earlier comment on styling, would it be good to change the style of devtool icon (currently px) to rem?
@jayasanka-sack
Twiineenock
pushed a commit
to Twiineenock/openmrs-esm-core
that referenced
this pull request
Jul 18, 2024
…nmrs#1079) * Styling the devtools and help menu * move devtools styles in rem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR moves help menu icon to the position of dev tools and vice versa with reference to this comment
Screenshots
Related Issue
O3-3579