Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locate the various toolbar-type widgets in the global header #8

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

jona42-ui
Copy link
Collaborator

@jona42-ui jona42-ui commented Oct 4, 2023

Related discussion

#5 (comment)

Screenshot from 2023-10-04 11-11-13

@jona42-ui
Copy link
Collaborator Author

Screenshot from 2023-10-03 20-06-52

@jona42-ui jona42-ui changed the title locate the various toolbar-type widgets either in the global header locate the various toolbar-type widgets in the global header Oct 4, 2023
@jona42-ui
Copy link
Collaborator Author

jona42-ui commented Oct 4, 2023

cc: @ibacher @brandones can you pliz give me some pointers here

@jona42-ui
Copy link
Collaborator Author

jona42-ui commented Oct 23, 2023

So basically i want this app to evolve independent of the form engine(either Amphath or ohri) such that it has a concrete ui/uix, then where need be; forexample if it needs to be incoporated/integrated with the form libraries as long as they support complex obs, it can be used when filling a form as a pop up editor , annotate, save & close and continue filling the form seemlessly.

So it may not need opening a new tab for the annotation tools.

cc @mks-d @samuelmale

@jona42-ui jona42-ui requested a review from mks-d October 23, 2023 09:40
@jona42-ui
Copy link
Collaborator Author

jona42-ui commented Oct 23, 2023

so generally speaking if we need a safe intergration, one should pass encounter information to the payload while submitting using the attachments module(thats the annotated clinical image) it should tie that observation to the encounter. am not sure if this is already supported in the AFE because what I remember was us having a custom control for diagrams for embedding diagrams?

But for now id having a concrete ux with editing tools.

cc; @ibacher @mks-d

@jona42-ui
Copy link
Collaborator Author

so generally speaking if we need a safe intergration, one should pass encounter information to the payload while submitting using the attachments module(thats the annotated clinical image) it should tie that observation to the encounter. am not sure if this is already supported in the AFE because what I remember was us having a custom control for diagrams for embedding diagrams?

But for now id having a concrete ux with editing tools.

cc; @ibacher @mks-d

this has been merged here
openmrs/openmrs-esm-form-engine-lib#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant