Skip to content

(fix) O3-3415 : Update scroll height in form-renderer and interactive #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Muta-Jonathan
Copy link
Member

@Muta-Jonathan Muta-Jonathan commented Dec 12, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Fixing the height of the form-renderer and interactive builder, and including a scrollbar if contents overflow. This allows users to scroll through the content without altering the component's size

Screenshots

On Big Screen

Screen.Recording.2024-12-12.at.12.34.16.PM.mov

On Tabulate view

Screen.Recording.2024-12-12.at.12.36.13.PM.mov

Related Issue

https://openmrs.atlassian.net/browse/O3-3415

@Muta-Jonathan
Copy link
Member Author

@NethmiRodrigo NethmiRodrigo self-requested a review December 19, 2024 07:28
@NethmiRodrigo
Copy link
Collaborator

Sorry about the (extremely) late review @Muta-Jonathan. Thanks for taking this up! Could you please fix the horizontal scroll? There shouldn't be one

@Muta-Jonathan
Copy link
Member Author

Updated screen record here @NethmiRodrigo

Screen.Recording.2025-01-15.at.10.19.54.PM.mov

Copy link
Collaborator

@NethmiRodrigo NethmiRodrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Muta-Jonathan!

@NethmiRodrigo NethmiRodrigo merged commit 5d07aea into openmrs:main Jan 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants