Skip to content

OCLOMRS-1118: IsSet property of concept is not always set correctly #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mseaton merged 1 commit into from
Jan 9, 2026
Merged

OCLOMRS-1118: IsSet property of concept is not always set correctly #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions api/src/main/java/org/openmrs/module/openconceptlab/importer/Saver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,7 @@ public Concept toConcept(CacheService cacheService, OclConcept oclConcept) throw
setAllowDecimal(numeric, extras);
}

if (extras.getIsSet() != null) {
Copy link
Member

@mogoodrich mogoodrich Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, so it was setting it as a set if set was either 0 or 1? (not just null)?

Copy link
Member

@mogoodrich mogoodrich Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, never mind, I see now...

concept.setSet(extras.getIsSet() == 1);
}
concept.setSet(extras.getIsSet() != null && extras.getIsSet() == 1);

concept.setRetired(oclConcept.isRetired());
if (oclConcept.isRetired()) {
Expand Down Expand Up @@ -403,9 +401,6 @@ public Item saveMapping(final CacheService cacheService, final Import update, fi
if (oclMapping.getMapType().equals(MapType.Q_AND_A)) {
item = updateOrAddAnswersFromOcl(update, oclMapping, fromConcept, toConcept);
} else {
if (!fromConcept.getSet()) {
fromConcept.setSet(true);
Copy link
Member

@mogoodrich mogoodrich Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this was supposed to do, but this does look backwards!

}
item = updateOrAddSetMembersFromOcl(update, oclMapping, fromConcept, toConcept);
}

Expand Down Expand Up @@ -586,6 +581,8 @@ Item updateOrAddSetMembersFromOcl(Import update, OclMapping oclMapping, Concept
}
}

set.setSet(!set.getSetMembers().isEmpty());

return item;
}

Expand Down