-
Notifications
You must be signed in to change notification settings - Fork 52
Migrate to Platform 2.7.x #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| <version>1.9.13</version> | ||
| <scope>provided</scope> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-compress</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used in OclClient. I just updated the version of this dependency from 1.21 to 1.26.
| <groupId>javax.servlet</groupId> | ||
| <artifactId>javax.servlet-api</artifactId> | ||
| <version>4.0.1</version> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we change the scope from test?
| }, | ||
| "dependencies": { | ||
| "angular": "1.5.5", | ||
| "angular-ui-router": "^0.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the changes in this file required to run platform 2.7.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes happen automatically after running mvn clean install. I reverted them.
| @@ -1,8 +1,8664 @@ | |||
| { | |||
| "name": "openconceptlab", | |||
| "version": "1.2.0", | |||
| "lockfileVersion": 1, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the changes in this file required to run platform 2.7?
|
Did you eventually get a fix for the build failure? |
Nope, still looking into that test error. |
|
@wikumChamith did you figure this out? Or should i take a look at it? |
No description provided.