Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTWS-646:Optimize fetching all Concepts via Rest-WS #432

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RESTWS-646:Optimize fetching all Concepts via Rest-WS #432

wants to merge 1 commit into from

Conversation

sherrif10
Copy link
Member

@sherrif10 sherrif10 commented May 12, 2020

https://issues.openmrs.org/browse/RESTWS-646
This work is in progress , cc @dkayiwa @ibacher @mks-d @k-joseph kindly review and advise will be highly welcome, Another thing can be information from the reporter unfortunately he is currently off and we are not sure whether he is still blocked or not.
WHAT I DID
1 Upgraded the openmrversion from 1.9.10 to 1.11.6 for testing purposes.
2. Tried to use some a single loop and stringbuilder in conceptResource to optmize, like i said this is WIP

@sherrif10
Copy link
Member Author

I cant tell why the travis is failing, it doesnt show the logs with error problem, Am seeing the error could have arose from tests but still cant figure out with class is affected. cc

@ibacher
Copy link
Member

ibacher commented May 13, 2020

@sherrif10 The test error looks a bit weird. But let me give you some pointers on this PR instead.

We don't want to change the support OpenMRS version. This could easily be why the test failure occurs, because the test is written against OpenMRS 1.8 and doesn't work on 1.11.

To implement this specific change, don't make any changes to the 1.8 version of the resource, but instead add this doGetAll() method to the ConceptResource1_11 in the omod-1.11 submodule (which already depends on OpenMRS 1.11). Then simply change the @Resource annotation on the ConceptResource1_8 class to indicate that it supports OpenMRS 1.8 only and modify the ConceptResource1_11 to support the rest of the OpenMRS versions up to 2.4.

@ibacher ibacher force-pushed the master branch 2 times, most recently from f9c73bb to 2a4407f Compare December 14, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants