RESTWS-942 - Obs for a Concept Numeric with allowDecimal = false shou…

[mseaton]

…ld not return a decimal as a value

See: https://openmrs.atlassian.net/browse/RESTWS-942

[coveralls]

coverage: 47.138% (+0.02%) from 47.118%
when pulling ebc27c9 on RESTWS-942
into 14e6f5b on master.

[mogoodrich]

LGTM!

[dkayiwa]

@mseaton could there be a reason why you did not just fix this in core on the line that @chibongho pointed at?

[mseaton]

@mseaton could there be a reason why you did not just fix this in core on the line that @chibongho pointed at?

I did fix it there @dkayiwa , in a different PR associated with core that I tagged you on. But that wouldn't fix this issue AFAIK, as the issue in core is in the getValueAsString method, whereas this REST response is the actual value itself (not necessarily as a string).

[dkayiwa]

whereas this REST response is the actual value itself (not necessarily as a string).

But the value will not have a decimal point because it was not stored with it in the first place. So obs.getValueNumeric() would fetch it as expected. Not so?

[mseaton]

But the value will not have a decimal point because it was not stored with it in the first place. So obs.getValueNumeric() would fetch it as expected. Not so?

I don't see why that would be. It's a double in the DB. Whether 40 or 40.0 is saved originally, the value in the db would be the same. It's how it is read out and converted from a Double to an Integer that matters in the end, right?

[dkayiwa]

Correct! 😊