Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTWS-954: Ensures session endpoint returns locale even when user is not logged in #621

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

mherman22
Copy link
Member

@mherman22 mherman22 commented Sep 7, 2024

Description of what I changed

Made sure we have locale details in the json return when a user is not logged. The json below is extracted from the network after dropping an omod file with the changes into a local server to test the changes in this PR.

{
  "authenticated": false,
  "locale": "en",
  "allowedLocales": [
    "en",
    "en-GB",
    "es",
    "fr",
    "he",
    "km",
    "ar"
  ]
}

Issue I worked on

see https://issues.openmrs.org/browse/RESTWS-954

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@ibacher ibacher merged commit 07fd727 into openmrs:master Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants