Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-3437: Update SDK to bundle SPA frontend into WAR #281

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

wikumChamith
Copy link
Member

Description of what I changed

This makes the SDK's bundled option builds and includes the frontend in the .war file

Issue I worked on

see https://openmrs.atlassian.net/browse/O3-3430

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean install right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute the above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@wikumChamith wikumChamith requested review from ibacher and dkayiwa August 2, 2024 13:00
@wikumChamith wikumChamith changed the title O3-3430: Bundle WAR file to contain all modules including SPA O3-3437: Update SDK to bundle SPA frontend into WAR Aug 2, 2024
@ibacher
Copy link
Member

ibacher commented Aug 2, 2024

This probably needs to be paired with a commit to core or the SPA module that will actually do something with this directory.

@wikumChamith
Copy link
Member Author

This probably needs to be paired with a commit to core or the SPA module that will actually do something with this directory.

Can we merge this and move on to that?

@ibacher
Copy link
Member

ibacher commented Aug 2, 2024

Can we merge this and move on to that?

Yes!

@wikumChamith wikumChamith merged commit c25a970 into openmrs:master Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants