SDK-332: Correct the O3 Versions displayed during setup of an instance #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mherman22
changed the title
ibacher
reviewed
Aug 20, 2024
| for (ArtifactVersion version : versionsHelper.getAllVersions(artifact, MAX_OPTIONS_SIZE)) { | ||
| optionsMap.put(String.format(optionTemplate, version.toString()), artifact.getGroupId() + ":" + artifact.getArtifactId() + ":" + version); | ||
|
|
||
| Artifact artifact = new Artifact("referenceapplication-distro", "3.0.0-beta.21", "org.openmrs.distro", "zip"); |
There was a problem hiding this comment.
Is there any reason not to just use 3.0.0 here?
Comment on lines
72
to
73
| versions.removeIf(version -> "3.1.0-SNAPSHOT".equals(version.toString())); | ||
| versions.removeIf(version -> "3.0.0-SNAPSHOT".equals(version.toString())); |
There was a problem hiding this comment.
This looks like it will require continuous maintenance. Is there any way we can automate this, i.e., drop any -SNAPSHOT versions that are < the first non-SNAPSHOT version?
There was a problem hiding this comment.
Makes sense, lemi make the change
ibacher
reviewed
Aug 20, 2024
Comment on lines
72
to
73
| versions.removeIf(version -> "3.1.0-SNAPSHOT".equals(version.toString())); | ||
| versions.removeIf(version -> "3.0.0-SNAPSHOT".equals(version.toString())); |
There was a problem hiding this comment.
Ooh... I don't exactly like doing this because we'd need to constantly maintain this. Is there a way we can write some logic that would
ibacher
approved these changes
Aug 28, 2024
| @@ -782,11 +782,11 @@ private Map<String, String> getDistroVersionsOptionsMap(Set<String> versions, Ve | |||
| * @return A LinkedHashMap containing the generated options map. | |||
| */ | |||
| private Map<String, String> getO3VersionsOptionsMap(VersionsHelper versionsHelper, | |||
| String optionTemplate) { | |||
| String optionTemplate) { | |||
There was a problem hiding this comment.
Could we undo the change to this line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
see https://openmrs.atlassian.net/browse/SDK-332
screenshot(s)
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean installright before creating this pull request andadded all formatting changes to my commit.
No? -> execute the above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master