O3-3434: SDK Command: Remove dependencies from distro.properties #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Aug 27, 2024
|
|
||
| Properties properties = new Properties(); | ||
|
|
||
| if(StringUtils.isNotBlank(distro)) { |
There was a problem hiding this comment.
It would be great to always put space after if
ibacher
requested changes
Aug 28, 2024
| import java.util.Properties; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| @Mojo(name = "rm-dependency", requiresProject = false) |
There was a problem hiding this comment.
I'd prefer this was just named remove. I don't think rm-dependency is very intuitive of a name...
| if (distroFile.exists()) { | ||
| distro = distroFile.getAbsolutePath(); | ||
| } | ||
| } |
There was a problem hiding this comment.
So what happens here if there's no distro file in the local directory and none supplied?
Comment on lines
56
to
57
| properties.remove(property); | ||
| DistroProperties distroProperties = new DistroProperties(properties); |
There was a problem hiding this comment.
Shouldn't we just move remove() to DistroProperties? That seems like that removes the need to add getProperties() and then create a new DistroProperties object, no?
integration-tests/pom.xml
Outdated
| @@ -42,5 +42,9 @@ | |||
| <artifactId>hamcrest-library</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.mockito</groupId> | |||
There was a problem hiding this comment.
IS this addition actually required? We shouldn't be using mocks in integration tests unless its unavoidable.
|
@ibacher I updated the PR. |
ibacher
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
This adds a plugin that allows users to manipulate a distro.properties file by removing dependencies.
Issue I worked on
see https://openmrs.atlassian.net/browse/O3-3434
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean installright before creating this pull request andadded all formatting changes to my commit.
No? -> execute the above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master