Skip to content

Conversation

sommeeeer
Copy link
Collaborator

@sommeeeer sommeeeer commented Sep 3, 2025

The event listener on these tests should be registered before the navigation. Before this PR these tests would never invoke the callback.

When you have enabled the cache interception, the rewrite status code from middleware would not be propogated to the response. There is a follow-up PR coming in AWS to take care of this problem.

Also added a test for x-opennext-requestid.

Depends on opennextjs/opennextjs-aws#974

DO NOT MERGE BEFORE ^

Note: As you can see in the job on this PR this test fails, cause we need to propogate the rewrite status code properly in the cache interceptor. We can rerun the E2E on this PR, once the fix in AWS is released and we have bumped to it.

Copy link

changeset-bot bot commented Sep 3, 2025

⚠️ No Changeset found

Latest commit: a92727a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Sep 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@873

commit: a92727a

@vicb vicb changed the title fix(e2e): Ensure the response event listener is registered before navigation [BLOCKED on aws release] fix(e2e): Ensure the response event listener is registered before navigation Sep 4, 2025
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I added a few minor comments.

@sommeeeer
Copy link
Collaborator Author

Thanks Victor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants