-
Notifications
You must be signed in to change notification settings - Fork 67
[BLOCKED on aws release] fix(e2e): Ensure the response event listener is registered before navigation #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I added a few minor comments.
Thanks Victor! |
The event listener on these tests should be registered before the navigation. Before this PR these tests would never invoke the callback.
When you have enabled the cache interception, the rewrite status code from middleware would not be propogated to the response. There is a follow-up PR coming in AWS to take care of this problem.
Also added a test for
x-opennext-requestid
.Depends on opennextjs/opennextjs-aws#974
DO NOT MERGE BEFORE ^
Note: As you can see in the job on this PR this test fails, cause we need to propogate the rewrite status code properly in the cache interceptor. We can rerun the E2E on this PR, once the fix in AWS is released and we have bumped to it.