Annotations required updated #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odscrachel
approved these changes
Aug 9, 2024
|
@kd-ods I think this ok to merge as won't actually impact the 0.4.0 branch but tagging for a sense check when you're back. Also should we be merging this in to 0.4.0 or 0.4.1 maybe? |
kathryn-ods
added a commit
that referenced
this pull request
Jan 8, 2025
* removing uneeded fields from conditional * removing uneeded fields from conditional * removing uneeded fields from conditional * adding in required fields
kathryn-ods
added a commit
that referenced
this pull request
Jan 16, 2025
This reverts commit cd357cf.
kathryn-ods
added a commit
that referenced
this pull request
Jan 22, 2025
* corrected record-ids * Annotations required updated (#722) * removing uneeded fields from conditional * removing uneeded fields from conditional * removing uneeded fields from conditional * adding in required fields * corrected record-ids * removing the defunct google analytics tracking and replacing with plausible (#736) * Example drt main (#735) * removing min and max from shares where exact is present swapping 2 letter iso country for 3 digit swapping 2 letter iso country for 3 digit fixing shares and componentRecords fixing midindent removing duplicate statement Id fixing midindent fixing shares fixing component records * examples fixes * examples fixes * removing broken link * readding broken link * Update listed-company-exempt-from-disclosure.json entity didn't have hasPublicListing true * fixing indentation * Update multiple-indirect-ownership.json making statementDate consistent * Update multiple-tax-residencies.json making dates consistent --------- Co-authored-by: kd-ods <35495305+kd-ods@users.noreply.github.com> * replacing xxxx with an example name * Revert "Annotations required updated (#722)" This reverts commit cd357cf. --------- Co-authored-by: kd-ods <kadie.armstrong@opendataservices.coop> Co-authored-by: kd-ods <35495305+kd-ods@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What does this pull request do? fixes #721
How can a reviewer test or examine your changes?
check all the tests pass, build the docs and check the expected fields now show as required
Who is best placed to review it?
Closes #
Translations
translating. See the Handbook
Documentation & Release