Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4.0 examples patch #740

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

0.4.0 examples patch #740

wants to merge 6 commits into from

Conversation

kathryn-ods
Copy link
Contributor

Overview

What does this pull request do?
cherry picking from main

fixes errors in the 0.4.0 branch examples and sets up plausible tracking

How can a reviewer test or examine your changes?
I have run these through the DRT tool and checked these are the same as main

Who is best placed to review it?

Closes #

Translations

  • New or edited strings appearing as a result of this PR will be picked up for translation
  • I've notified the translation coordinator of any new strings that will need
    translating. See the Handbook

Documentation & Release

kd-ods and others added 6 commits January 8, 2025 12:01
* removing uneeded fields from conditional

* removing uneeded fields from conditional

* removing uneeded fields from conditional

* adding in required fields
* removing min and max from shares where exact is present

swapping 2 letter iso country for 3 digit

swapping 2 letter iso country for 3 digit

fixing shares and componentRecords

fixing midindent

removing duplicate statement Id

fixing midindent

fixing shares

fixing component records

* examples fixes

* examples fixes

* removing broken link

* readding broken link

* Update listed-company-exempt-from-disclosure.json

entity didn't have hasPublicListing true

* fixing indentation

* Update multiple-indirect-ownership.json

making statementDate consistent

* Update multiple-tax-residencies.json

making dates consistent

---------

Co-authored-by: kd-ods <35495305+kd-ods@users.noreply.github.com>
@kathryn-ods kathryn-ods requested a review from kd-ods January 8, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants