test_additional_fields_0_4_0.py: Add test

libcovebods/tasks/checks.py

@@ -1061,7 +1061,7 @@ def check_ownership_or_control_statement_first_pass(self, statement):
                                 {
                                     "type": "statement_relationship_interests_start_after_end_date",
                                     "statement_type": None,
-                                    "start_date": start_end,
+                                    "start_date": start_date,
                                     "end_start": end_date,
                                     "statement": statement.get("statementId"),
                                 }
@@ -1828,7 +1828,7 @@ def check_person_statement_first_pass(self, statement):
                             "type": "person_identifiers_invalid_composition",
                             "statement_type": None,
                             "statement": statement.get("statementId"),
-                            "scheme": identifier["scheme"],
+                            "scheme": identifier["scheme"] if "scheme" in identifier else None,
                         }
                     )
                 else:

tests/fixtures/0.4/additional_fields_1.json

@@ -0,0 +1,17 @@
+[
+  {
+    "statementId": "1dc0e987-5c57-4a1c-b3ad-61353b66a9b7",
+    "extratestfield1": "test",
+    "declarationSubject": "c359f58d2977",
+    "statementDate": "2020-03-04",
+    "recordId": "c359f58d2977",
+    "recordType": "entity",
+    "recordDetails": {
+      "extratestfield2": "test",
+      "isComponent": false,
+      "entityType": {
+        "type": "registeredEntity"
+      }
+    }
+  }
+]

tests/test_additional_fields_0_4_0.py

@@ -0,0 +1,26 @@
+import json
+import os
+import tempfile
+
+from tests.api import bods_json_output
+
+
+def test_additional_fields_1():
+
+    cove_temp_folder = tempfile.mkdtemp(
+        prefix="lib-cove-bods-tests-", dir=tempfile.gettempdir()
+    )
+    json_filename = os.path.join(
+        os.path.dirname(os.path.realpath(__file__)), "fixtures", "0.4", "additional_fields_1.json"
+    )
+
+    results = bods_json_output(cove_temp_folder, json_filename)
+
+    print(results)
+
+    assert results["schema_version"] == "0.4"
+    assert results["validation_errors_count"] == 0
+    assert results["additional_fields_count"] == 2
+    assert results["additional_checks_count"] == 0
+
+    assert False