modified TD and ED calculations and added tests #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbnkmp
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Mods.R line 314/315: Add in doc title that it could also be an maFit object?
Mods.R line 351: Add in the documentation that all doses need to be <= the maximum dose used in the trial?
Mods.R, line 392/420: Is it obvious what any(doses > maxD) returns when doses == NULL? Maybe only check for any(doses > maxD) only when TDtype or EDtype == "discrete"?
Mods.R line 459/563: If doses has default argument NULL, is it better to test for doses == NULL rather than missing(doses)?
Mods.R new line 588: Don't understand this.
Mods_helpers.R new line 609: Don't understand this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.