Skip to content

Issue 557: CICD must fail on error#558

Merged
luwidmer merged 6 commits intomainfrom
557-cicd-must-fail-on-error
Mar 17, 2026
Merged

Issue 557: CICD must fail on error#558
luwidmer merged 6 commits intomainfrom
557-cicd-must-fail-on-error

Conversation

@luwidmer
Copy link
Collaborator

@luwidmer luwidmer commented Mar 5, 2026

Fixes #557

@luwidmer luwidmer requested a review from gowerc March 5, 2026 17:13
@luwidmer luwidmer marked this pull request as draft March 5, 2026 17:14
@luwidmer luwidmer marked this pull request as ready for review March 5, 2026 17:14
@luwidmer luwidmer changed the title Issue 557: CI/CD must fail on error Issue 557: CICD must fail on error Mar 5, 2026
@luwidmer
Copy link
Collaborator Author

luwidmer commented Mar 9, 2026

This now correctly fails with

── Failed tests ────────────────────────────────────────────────────────────────
Error ('test-spelling.R:18:13'): spelling
Error: Potential spelling errors:
  WORD        FOUND IN
Github      NEWS.md:10
NMAR        NEWS.md:5
Robustify   NEWS.md:10
favor       NEWS.md:8
lifecycle   NEWS.md:7
If these are false positive, run `spelling::update_wordlist()`.

@luwidmer luwidmer requested a review from gravesti March 9, 2026 15:38
@luwidmer
Copy link
Collaborator Author

luwidmer commented Mar 9, 2026

@gowerc @gravesti this is ready for review now, I think

@luwidmer
Copy link
Collaborator Author

@gravesti / @gowerc does this work for you?

@gravesti
Copy link
Collaborator

This looks alright to me 👍

@luwidmer
Copy link
Collaborator Author

@gravesti could you approve the review step 🙂?

Copy link
Collaborator

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luwidmer

@luwidmer luwidmer merged commit 0f999e8 into main Mar 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing core and extended tests do not fail the CI/CD pipeline

2 participants