Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an email interceptor functionality to prevent emails from being sent to unintended recipients in non-production environments. It allows administrators to configure a list of allowed email addresses or domains, and any outgoing emails will be filtered to only include recipients that match this allowed list.
Key Changes:
- Implemented a mail interceptor that filters outgoing emails based on an allowed recipients list configured via environment variable
- Added support for both exact email matching and domain-based pattern matching (e.g., @pokecode.net)
- Included comprehensive test coverage for various filtering scenarios including case-insensitive matching
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/mailers/decidim/pokecode/mail_interceptor.rb | Core implementation of the mail interceptor with filtering logic for to/cc/bcc recipients |
| lib/decidim/pokecode/configuration.rb | Adds configuration accessor for ALLOWED_RECIPIENTS environment variable and helper method to parse the list |
| lib/decidim/pokecode/engine.rb | Registers the mail interceptor during Rails initialization when allowed recipients are configured |
| spec/lib/mail_interceptor_spec.rb | Comprehensive test suite covering domain matching, exact email matching, case sensitivity, and mixed recipient scenarios |
| README.md | Documents the new ALLOWED_RECIPIENTS environment variable with usage examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…e-pokecode into email-interceptor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.