Add proposal answer templates #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
changed the title
microstudi
requested changes
Oct 11, 2022
There was a problem hiding this comment.
Thanks @alecslupu
excelent work.
I've left some notes on trivial things, a change of a copy and a question.
A part from that, could you check the failing tests and the linting? thanks!
decidim-templates/app/commands/decidim/templates/admin/copy_proposal_answer_template.rb
Outdated
Show resolved
Hide resolved
decidim-templates/spec/system/admin/admin_manages_proposal_answer_templates_spec.rb
Outdated
Show resolved
Hide resolved
decidim-templates/spec/system/admin/admin_manages_proposal_answer_templates_spec.rb
Outdated
Show resolved
Hide resolved
decidim-templates/app/commands/decidim/templates/admin/create_proposal_answer_template.rb
Outdated
Show resolved
Hide resolved
decidim-templates/app/commands/decidim/templates/admin/destroy_questionnaire_template.rb
Show resolved
Hide resolved
...im-templates/app/controllers/decidim/templates/admin/proposal_answer_templates_controller.rb
Outdated
Show resolved
Hide resolved
...im-templates/app/controllers/decidim/templates/admin/proposal_answer_templates_controller.rb
Outdated
Show resolved
Hide resolved
decidim-templates/app/views/decidim/templates/admin/proposal_answer_templates/index.html.erb
Outdated
Show resolved
Hide resolved
This was referenced Oct 16, 2022
8 tasks
alecslupu
commented
Jan 10, 2023
...im-templates/app/controllers/decidim/templates/admin/proposal_answer_templates_controller.rb
Show resolved
Hide resolved
...im-templates/app/controllers/decidim/templates/admin/proposal_answer_templates_controller.rb
Show resolved
Hide resolved
alecslupu
commented
Jan 10, 2023
decidim-templates/app/commands/decidim/templates/admin/create_proposal_answer_template.rb
Show resolved
Hide resolved
This was referenced Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Please describe your pull request.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📷 Screenshots
Please add screenshots of the changes you're proposing
