Skip to content

Use pre-computed distances in metrics #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 18, 2024
Merged

Conversation

lazappi
Copy link
Member

@lazappi lazappi commented Dec 9, 2024

Describe your changes

  • Add calculation of distances to/between waypoints and label centroids to dataset pre-processing
  • Add a post-processing component that calculates distances in the embedding space
  • Modify co-ranking metrics to use pre-computed distances
  • Modify distance correlation metrics to use pre-computed distances
  • Add to centroid and between label distance correlation scores
  • Move spectral distance correlation to a separate component
  • Update documentation for distance correlation metrics
  • Disable the trustworthiness metric as it is calculated as part of the co-ranking metrics

Fixes #7

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@lazappi lazappi requested a review from rcannood December 9, 2024 10:32
@lazappi
Copy link
Member Author

lazappi commented Dec 9, 2024

@rcannood The CI can't find the new test resources. I have synced them to S3, is there something else I need to do?

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines 64 to +66
shape = input$shape
)
output$obs_names <- input$obs_names
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI -- I think I sometimes solve this by:

Suggested change
shape = input$shape
)
output$obs_names <- input$obs_names
obs = input$obs[,integer(0)],
var = input$var[,integer(0)]
)

@rcannood
Copy link
Member

rcannood commented Dec 10, 2024

@rcannood The CI can't find the new test resources. I have synced them to S3, is there something else I need to do?

This is an issue with the caching -- Removing the cache resolved the issue.

Update: Should be resolved with viash-io/viash-actions@v6.6.1

@lazappi lazappi merged commit 57a732c into main Dec 18, 2024
9 checks passed
@lazappi lazappi deleted the feature/issue-8/waypoints branch December 18, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use waypoints and/or label centroids for pairwise distance metrics
2 participants