-
Notifications
You must be signed in to change notification settings - Fork 2
Use pre-computed distances in metrics #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Calculates distances on the embedding output
Also calculated as part of the co-ranking metrics
@rcannood The CI can't find the new test resources. I have synced them to S3, is there something else I need to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
shape = input$shape | ||
) | ||
output$obs_names <- input$obs_names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI -- I think I sometimes solve this by:
shape = input$shape | |
) | |
output$obs_names <- input$obs_names | |
obs = input$obs[,integer(0)], | |
var = input$var[,integer(0)] | |
) |
This is an issue with the caching -- Removing the cache resolved the issue. Update: Should be resolved with viash-io/viash-actions@v6.6.1 |
Describe your changes
Fixes #7
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!