Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Viash 0.9 #71

Merged
merged 11 commits into from
Jul 15, 2024
Merged

Update to Viash 0.9 #71

merged 11 commits into from
Jul 15, 2024

Conversation

rcannood
Copy link
Member

@rcannood rcannood commented Jul 2, 2024 •
edited
Loading

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality (new method, new metric, ...)
    • Major changes
    • Minor changes
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@rcannood rcannood requested a review from KaiWaldrant July 12, 2024 05:48
KaiWaldrant
KaiWaldrant approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@KaiWaldrant KaiWaldrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions

src/control_methods/ground_truth/config.vsh.yaml Outdated Show resolved Hide resolved
src/control_methods/mean_across_celltypes/config.vsh.yaml Outdated Show resolved Hide resolved
src/control_methods/mean_across_compounds/config.vsh.yaml Outdated Show resolved Hide resolved
src/control_methods/mean_outcome/config.vsh.yaml Outdated Show resolved Hide resolved
src/control_methods/sample/config.vsh.yaml Outdated Show resolved Hide resolved
src/process_dataset/filter_obs/config.vsh.yaml Outdated Show resolved Hide resolved
src/process_dataset/filter_vars/config.vsh.yaml Outdated Show resolved Hide resolved
src/process_dataset/generate_id_map/config.vsh.yaml Outdated Show resolved Hide resolved
src/process_dataset/generate_id_map/config.vsh.yaml Outdated Show resolved Hide resolved
src/process_dataset/run_limma/config.vsh.yaml Outdated Show resolved Hide resolved
@rcannood @KaiWaldrant
Apply suggestions from code review
121eb05 
Co-authored-by: Kai Waldrant <kai@data-intuitive.com>
KaiWaldrant
KaiWaldrant reviewed Jul 12, 2024
View reviewed changes
src/methods/nn_retraining_with_pseudolabels/config.vsh.yaml Outdated
Comment on lines 45 to 46
- type: apt
packages:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove packages from line 45 - 54

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

rcannood and others added 2 commits July 15, 2024 22:55
@rcannood @KaiWaldrant
Apply suggestions from code review
6d41f80 
Co-authored-by: Kai Waldrant <kai@data-intuitive.com>
@rcannood @KaiWaldrant
apply suggestions
a1fc69c 
Co-authored-by: Kai Waldrant <kai@data-intuitive.com>
@rcannood rcannood merged commit 02def51 into main Jul 15, 2024
2 checks passed
@rcannood rcannood deleted the viash0.9 branch July 15, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiWaldrant KaiWaldrant KaiWaldrant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcannood @KaiWaldrant