Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PythonParser will return PlainSource sources if the Python remoting server couldn't be started #86

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

knutwannheden
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/python/ChangeMethodNameTest.java
    • lines 20-22
  • src/test/java/org/openrewrite/python/tree/MethodInvocationTest.java
    • lines 23-23
  • src/test/java/org/openrewrite/python/tree/package-info.java
    • lines 20-20

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/python/ChangeMethodNameTest.java
    • lines 20-22
  • src/test/java/org/openrewrite/python/tree/MethodInvocationTest.java
    • lines 23-23
  • src/test/java/org/openrewrite/python/tree/package-info.java
    • lines 20-20

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/python/ChangeMethodNameTest.java
    • lines 20-22
  • src/test/java/org/openrewrite/python/tree/MethodInvocationTest.java
    • lines 23-23
  • src/test/java/org/openrewrite/python/tree/package-info.java
    • lines 20-20

@knutwannheden knutwannheden changed the title TODOs for PythonParser PythonParser will return PlainSource sources if the Python remoting server couldn't be started Aug 29, 2024
@knutwannheden knutwannheden marked this pull request as ready for review August 29, 2024 08:15
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/python/ChangeMethodNameTest.java
    • lines 20-22
  • src/test/java/org/openrewrite/python/tree/MethodInvocationTest.java
    • lines 23-23
  • src/test/java/org/openrewrite/python/tree/package-info.java
    • lines 20-20

@knutwannheden knutwannheden merged commit 394ddef into main Aug 29, 2024
2 checks passed
@knutwannheden knutwannheden deleted the python-parser branch August 29, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant